Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blog - Final Project] HCL Frontend Integration for AMC #422

Merged
merged 29 commits into from
Dec 23, 2023
Merged

[Blog - Final Project] HCL Frontend Integration for AMC #422

merged 29 commits into from
Dec 23, 2023

Conversation

matth2k
Copy link
Contributor

@matth2k matth2k commented Dec 11, 2023

This is the blog post for the final project by @yxd97 and I.

@matth2k
Copy link
Contributor Author

matth2k commented Dec 11, 2023

Fixes #400

@matth2k matth2k changed the title [Blog - Final Project] Allo Frontend Integration for AMC [Blog - Final Project] HCL Frontend Integration for AMC Dec 12, 2023
sampsyo
sampsyo requested changes Dec 17, 2023
View reviewed changes
Copy link
Owner

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Matt and Yixiao—really nice work on the writeup here! I found it very clear and direct. And nice work on the broader AMC project more broadly, of course. 😃 I have just a couple of minor suggestions where you could add a tiny bit more detail!

content/blog/2023-12-09-hcl-amc/index.md Outdated Show resolved Hide resolved
content/blog/2023-12-09-hcl-amc/index.md Outdated Show resolved Hide resolved
content/blog/2023-12-09-hcl-amc/index.md Show resolved Hide resolved
content/blog/2023-12-09-hcl-amc/index.md Show resolved Hide resolved
content/blog/2023-12-09-hcl-amc/index.md Show resolved Hide resolved
content/blog/2023-12-09-hcl-amc/index.md Show resolved Hide resolved
content/blog/2023-12-09-hcl-amc/index.md Show resolved Hide resolved
content/blog/2023-12-09-hcl-amc/index.md Outdated Show resolved Hide resolved
@matth2k
Copy link
Contributor Author

matth2k commented Dec 17, 2023

@sampsyo Thanks for pointing out all the spots that need clarification. It's very helpful feedback. I'll address all these points eventually and update the PR.

@matth2k
Copy link
Contributor Author

matth2k commented Dec 20, 2023

I think I addressed all of the comments. Feel free to let me know if it needs any more refinement.

sampsyo
sampsyo approved these changes Dec 23, 2023
View reviewed changes
Copy link
Owner

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; this looks really great! Nice work!!

@sampsyo sampsyo merged commit 32843e5 into sampsyo:2023fa Dec 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampsyo sampsyo sampsyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matth2k @sampsyo @yxd97