-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of CRAM 3.1 codecs. #1714
Open
cmnbroad
wants to merge
31
commits into
master
Choose a base branch
from
cn_cram_3_1_codecs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
306459c
Implementation of CRAM 3.1 codecs.
dd9b17e
Many FQZComp fixes, with roundtrip tests working.
cmnbroad 9534f3d
Name tokenization codec fixes.
cmnbroad 36d8622
Interop test data from htslib.
cmnbroad 0f7c991
Remove unnecessary mac files.
cmnbroad ce7430f
Use shared rans decoder in interop tests.
cmnbroad ca64055
Update useArith type in name tokenizer, remove unecessary object crea…
cmnbroad 56b8322
Remove sketchy exception suppression, make test encoding params type-…
cmnbroad d354ab2
Code cleanup.
cmnbroad f7a4ee6
Store token stream in arrays instead of lists.
cmnbroad ea0b8b2
More naming, removal of unnecessary code, switch sanitization.
cmnbroad 8559902
Temp update.
cmnbroad 561595d
Precompile regular expression patterns, optimize some string operatio…
cmnbroad 7777e24
Checkpoint 1.
cmnbroad fdc2153
Checkpoint 2.
cmnbroad d7f2095
Repair haphazard stream management.
cmnbroad d39ddc0
Consolidate and optimize, remove unecessary code.
cmnbroad 70665d1
Fix spotbugs issue.
cmnbroad 22e0dfa
Remove unnecessary code.
cmnbroad 2f3ce74
Fix sketchy byte conversion to use UTF-8 charset for names.
cmnbroad a8a7e55
Remove obsolete comment.
cmnbroad a71f9a9
Upgrade to samtools 1.21.
cmnbroad bdf9338
Remove redundant/duplicate tests.
cmnbroad bad9ece
Eliminate intermediate String representation for decoded names.
cmnbroad 91c1cce
Standardize input/output read name buffer separator.
cmnbroad 2b4ffd8
Update name separator handling.
cmnbroad b543c57
Comment update.
cmnbroad 7a50f40
Remove old interop data.
cmnbroad 71e7145
Add updated interop test files.
cmnbroad a37b995
Remove .DS_Store files.
cmnbroad 282322a
Conform to updated interop test structure.
cmnbroad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
178 changes: 178 additions & 0 deletions
178
src/main/java/htsjdk/samtools/cram/compression/CompressionUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,178 @@ | ||
package htsjdk.samtools.cram.compression; | ||
|
||
import htsjdk.samtools.cram.CRAMException; | ||
import htsjdk.samtools.cram.compression.rans.Constants; | ||
|
||
import java.nio.ByteBuffer; | ||
import java.nio.ByteOrder; | ||
|
||
public class CompressionUtils { | ||
public static void writeUint7(final int i, final ByteBuffer cp) { | ||
int s = 0; | ||
int X = i; | ||
do { | ||
s += 7; | ||
X >>= 7; | ||
} while (X > 0); | ||
do { | ||
s -= 7; | ||
//writeByte | ||
final int s_ = (s > 0) ? 1 : 0; | ||
cp.put((byte) (((i >> s) & 0x7f) + (s_ << 7))); | ||
} while (s > 0); | ||
} | ||
|
||
public static int readUint7(final ByteBuffer cp) { | ||
int i = 0; | ||
int c; | ||
do { | ||
//read byte | ||
c = cp.get(); | ||
i = (i << 7) | (c & 0x7f); | ||
} while ((c & 0x80) != 0); | ||
return i; | ||
} | ||
|
||
public static ByteBuffer encodePack( | ||
final ByteBuffer inBuffer, | ||
final ByteBuffer outBuffer, | ||
final int[] frequencyTable, | ||
final int[] packMappingTable, | ||
final int numSymbols){ | ||
final int inSize = inBuffer.remaining(); | ||
final ByteBuffer encodedBuffer; | ||
if (numSymbols <= 1) { | ||
encodedBuffer = CompressionUtils.allocateByteBuffer(0); | ||
} else if (numSymbols <= 2) { | ||
|
||
// 1 bit per value | ||
final int encodedBufferSize = (int) Math.ceil((double) inSize/8); | ||
encodedBuffer = CompressionUtils.allocateByteBuffer(encodedBufferSize); | ||
int j = -1; | ||
for (int i = 0; i < inSize; i ++) { | ||
if (i % 8 == 0) { | ||
encodedBuffer.put(++j, (byte) 0); | ||
} | ||
encodedBuffer.put(j, (byte) (encodedBuffer.get(j) + (packMappingTable[inBuffer.get(i) & 0xFF] << (i % 8)))); | ||
} | ||
} else if (numSymbols <= 4) { | ||
|
||
// 2 bits per value | ||
final int encodedBufferSize = (int) Math.ceil((double) inSize/4); | ||
encodedBuffer = CompressionUtils.allocateByteBuffer(encodedBufferSize); | ||
int j = -1; | ||
for (int i = 0; i < inSize; i ++) { | ||
if (i % 4 == 0) { | ||
encodedBuffer.put(++j, (byte) 0); | ||
} | ||
encodedBuffer.put(j, (byte) (encodedBuffer.get(j) + (packMappingTable[inBuffer.get(i) & 0xFF] << ((i % 4) * 2)))); | ||
} | ||
} else { | ||
|
||
// 4 bits per value | ||
final int encodedBufferSize = (int) Math.ceil((double)inSize/2); | ||
encodedBuffer = CompressionUtils.allocateByteBuffer(encodedBufferSize); | ||
int j = -1; | ||
for (int i = 0; i < inSize; i ++) { | ||
if (i % 2 == 0) { | ||
encodedBuffer.put(++j, (byte) 0); | ||
} | ||
encodedBuffer.put(j, (byte) (encodedBuffer.get(j) + (packMappingTable[inBuffer.get(i) & 0xFF] << ((i % 2) * 4)))); | ||
} | ||
} | ||
|
||
// write numSymbols | ||
outBuffer.put((byte) numSymbols); | ||
|
||
// write mapping table "packMappingTable" that converts mapped value to original symbol | ||
for(int i = 0; i < Constants.NUMBER_OF_SYMBOLS; i ++) { | ||
if (frequencyTable[i] > 0) { | ||
outBuffer.put((byte) i); | ||
} | ||
} | ||
|
||
// write the length of data | ||
CompressionUtils.writeUint7(encodedBuffer.limit(), outBuffer); | ||
return encodedBuffer; // Here position = 0 since we have always accessed the data buffer using index | ||
} | ||
|
||
public static ByteBuffer decodePack( | ||
final ByteBuffer inBuffer, | ||
final byte[] packMappingTable, | ||
final int numSymbols, | ||
final int uncompressedPackOutputLength) { | ||
final ByteBuffer outBufferPack = CompressionUtils.allocateByteBuffer(uncompressedPackOutputLength); | ||
int j = 0; | ||
if (numSymbols <= 1) { | ||
for (int i=0; i < uncompressedPackOutputLength; i++){ | ||
outBufferPack.put(i, packMappingTable[0]); | ||
} | ||
} | ||
|
||
// 1 bit per value | ||
else if (numSymbols <= 2) { | ||
int v = 0; | ||
for (int i=0; i < uncompressedPackOutputLength; i++){ | ||
if (i % 8 == 0){ | ||
v = inBuffer.get(j++); | ||
} | ||
outBufferPack.put(i, packMappingTable[v & 1]); | ||
v >>=1; | ||
} | ||
} | ||
|
||
// 2 bits per value | ||
else if (numSymbols <= 4){ | ||
int v = 0; | ||
for(int i=0; i < uncompressedPackOutputLength; i++){ | ||
if (i % 4 == 0){ | ||
v = inBuffer.get(j++); | ||
} | ||
outBufferPack.put(i, packMappingTable[v & 3]); | ||
v >>=2; | ||
} | ||
} | ||
|
||
// 4 bits per value | ||
else if (numSymbols <= 16){ | ||
int v = 0; | ||
for(int i=0; i < uncompressedPackOutputLength; i++){ | ||
if (i % 2 == 0){ | ||
v = inBuffer.get(j++); | ||
} | ||
outBufferPack.put(i, packMappingTable[v & 15]); | ||
v >>=4; | ||
} | ||
} | ||
return outBufferPack; | ||
} | ||
|
||
public static ByteBuffer allocateOutputBuffer(final int inSize) { | ||
// This calculation is identical to the one in samtools rANS_static.c | ||
// Presumably the frequency table (always big enough for order 1) = 257*257, | ||
// then * 3 for each entry (byte->symbol, 2 bytes -> scaled frequency), | ||
// + 9 for the header (order byte, and 2 int lengths for compressed/uncompressed lengths). | ||
final int compressedSize = (int) (inSize + 257 * 257 * 3 + 9); | ||
final ByteBuffer outputBuffer = allocateByteBuffer(compressedSize); | ||
if (outputBuffer.remaining() < compressedSize) { | ||
throw new CRAMException("Failed to allocate sufficient buffer size for RANS coder."); | ||
} | ||
return outputBuffer; | ||
} | ||
|
||
// returns a new LITTLE_ENDIAN ByteBuffer of size = bufferSize | ||
//TODO: rename this to allocateLittleEndianByteBuffer | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did you want to rename these? |
||
public static ByteBuffer allocateByteBuffer(final int bufferSize){ | ||
return ByteBuffer.allocate(bufferSize).order(ByteOrder.LITTLE_ENDIAN); | ||
} | ||
|
||
// returns a LITTLE_ENDIAN ByteBuffer that is created by wrapping a byte[] | ||
public static ByteBuffer wrap(final byte[] inputBytes){ | ||
return ByteBuffer.wrap(inputBytes).order(ByteOrder.LITTLE_ENDIAN); | ||
} | ||
|
||
// returns a LITTLE_ENDIAN ByteBuffer that is created by inputBuffer.slice() | ||
public static ByteBuffer slice(final ByteBuffer inputBuffer){ | ||
return inputBuffer.slice().order(ByteOrder.LITTLE_ENDIAN); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
src/main/java/htsjdk/samtools/cram/compression/RangeExternalCompressor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
package htsjdk.samtools.cram.compression; | ||
|
||
import htsjdk.samtools.cram.compression.range.RangeDecode; | ||
import htsjdk.samtools.cram.compression.range.RangeEncode; | ||
import htsjdk.samtools.cram.compression.range.RangeParams; | ||
import htsjdk.samtools.cram.structure.block.BlockCompressionMethod; | ||
|
||
import java.nio.ByteBuffer; | ||
|
||
public class RangeExternalCompressor extends ExternalCompressor{ | ||
|
||
private final int formatFlags; | ||
private final RangeEncode rangeEncode; | ||
private final RangeDecode rangeDecode; | ||
|
||
public RangeExternalCompressor( | ||
final RangeEncode rangeEncode, | ||
final RangeDecode rangeDecode) { | ||
this(0, rangeEncode, rangeDecode); | ||
} | ||
|
||
public RangeExternalCompressor( | ||
final int formatFlags, | ||
final RangeEncode rangeEncode, | ||
final RangeDecode rangeDecode) { | ||
super(BlockCompressionMethod.RANGE); | ||
this.rangeEncode = rangeEncode; | ||
this.rangeDecode = rangeDecode; | ||
this.formatFlags = formatFlags; | ||
} | ||
|
||
@Override | ||
public byte[] compress(byte[] data) { | ||
final RangeParams params = new RangeParams(formatFlags); | ||
final ByteBuffer buffer = rangeEncode.compress(CompressionUtils.wrap(data), params); | ||
return toByteArray(buffer); | ||
} | ||
|
||
@Override | ||
public byte[] uncompress(byte[] data) { | ||
final ByteBuffer buf = rangeDecode.uncompress(CompressionUtils.wrap(data)); | ||
return toByteArray(buf); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return String.format("%s(%s)", this.getMethod(),formatFlags); | ||
} | ||
|
||
private byte[] toByteArray(final ByteBuffer buffer) { | ||
if (buffer.hasArray() && buffer.arrayOffset() == 0 && buffer.array().length == buffer.limit()) { | ||
return buffer.array(); | ||
} | ||
|
||
final byte[] bytes = new byte[buffer.remaining()]; | ||
buffer.get(bytes); | ||
return bytes; | ||
} | ||
|
||
|
||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment describing what this method is for would be helpful