-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed frequency bars jitter [SG-122]
- Loading branch information
1 parent
f075eb3
commit dff51a3
Showing
28 changed files
with
94 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
src/components/game-modes/note-in-key/roadmap-selector/fret-shape-selector.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/components/game-modes/note-on-fretboard/note-on-fretboard-generator.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 5 additions & 7 deletions
12
src/components/game-modes/note-on-fretboard/note-on-fretboard-note-handler.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
src/components/game-modes/note-on-fretboard/note-on-fretboard-progress-updater.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
src/components/game-modes/note-on-fretboard/range-selector.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 14 additions & 6 deletions
20
src/features/game-core/frequency-bars/frequency-bars-controller.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,43 @@ | ||
import {FrequencyBarsVisualizer} from "./frequency-bars-visualizer.js?v=1708879136"; | ||
import {FrequencyBarsVisualizer} from "./frequency-bars-visualizer.js?v=2.1.1"; | ||
|
||
export class FrequencyBarsController { | ||
frequencyData = null; | ||
|
||
constructor(frequencyData) { | ||
this.frequencyBarsVisualizer = new FrequencyBarsVisualizer(); | ||
this.frequencyData = frequencyData; | ||
frequencyBarsVisualizer = null; | ||
|
||
constructor() { | ||
// Listen for the updateFrequencyBarsFillStyle event | ||
document.addEventListener('updateFrequencyBarsFillStyle', (event) => { | ||
this.frequencyBarsVisualizer.canvasContext.fillStyle = event.detail; | ||
}); | ||
} | ||
|
||
updateFrequencyBars(tuneOperator) { | ||
// requestAnimationFrame calls the function on the next frame but shouldn't if the game is paused | ||
if (!this.frequencyBarsVisualizer) { | ||
return; | ||
} | ||
if (tuneOperator.analyser) { | ||
tuneOperator.analyser.getByteFrequencyData(this.frequencyData); | ||
this.frequencyBarsVisualizer.update(this.frequencyData); | ||
} | ||
// console.log('updateFrequencyBars'); | ||
// requestAnimationFrame(this.updateFrequencyBars.bind(this)); | ||
requestAnimationFrame(() => this.updateFrequencyBars(tuneOperator)); | ||
}; | ||
|
||
static addFrequencyBarsAndDetectedNoteToDom() { | ||
addFrequencyBarsAndDetectedNoteToDom() { | ||
document.querySelector('#game-container').insertAdjacentHTML('beforeend', | ||
`<div id="detected-note-div"> | ||
<p id="detected-note"></p> | ||
</div> | ||
<canvas id="frequency-bars"></canvas>`); | ||
this.frequencyBarsVisualizer = new FrequencyBarsVisualizer(); | ||
} | ||
static removeFrequencyBarsAndDetectedNoteFromDom() { | ||
|
||
removeFrequencyBarsAndDetectedNoteFromDom() { | ||
document.querySelector('#frequency-bars')?.remove(); | ||
document.querySelector('#detected-note-div')?.remove(); | ||
this.frequencyBarsVisualizer = null; | ||
} | ||
} |
10 changes: 5 additions & 5 deletions
10
src/features/game-core/game-initialization/core-game-coordination-initializer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/features/game-core/game-initialization/game-configuration-manager.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
src/features/game-core/game-initialization/game-initializer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/features/game-modes/metronome/metronome-practice-coordinator.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
src/features/game-modes/metronome/metronome-practice-initializer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/features/game-modes/note-in-key/note-in-key-game-coordinator.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 9 additions & 9 deletions
18
src/features/game-modes/note-in-key/note-in-key-game-initializer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/features/game-modes/note-in-key/note-in-key-game-no-guitar.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/features/game-modes/note-on-fretboard/fretboard-note-game-coordinator.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
src/features/game-modes/note-on-fretboard/initialization/note-on-fretboard-event-handler.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...res/game-modes/note-on-fretboard/initialization/note-on-fretboard-event-listener-adder.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 5 additions & 7 deletions
12
...eatures/game-modes/note-on-fretboard/initialization/note-on-fretboard-game-initializer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
src/features/practice-note-combination/note-in-key-note-handler.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters