Move child works from 'relationships' to 'items' on work show page #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
force-pushed
the
show-items
branch
from
fd8c5f5 to
339987b
Compare
| <th>File</th> | ||
| <th>Filename</th> | ||
| <th></th> | ||
| <th>Title</th> |
There was a problem hiding this comment.
It would be nice if this was I18N instead of hardcoded.
|
@HackMasterA I'm trying to figure out what the column header that was removed looks like. Could you possibly add in a screenshot before and after to the PR? |
|
sure I'll take a screenshot. It said 'File' and then the column contained thumbnails which link to the show page (same as the title) |
|
Columns before this PR: After: I could change it to "thumbnail" or something. I just realized this might be an accessibility error. |
hackartisan
force-pushed
the
show-items
branch
from
339987b to
4bb36be
Compare
|
@Cam156 for reconsideration |
|
@HackMasterA Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2459