Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse annotations from linked external AnnotationPage(s) #754

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Parse annotations from linked external AnnotationPage(s) #754

merged 3 commits into from
Dec 17, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Dec 16, 2024

Related issue: #437

@Dananji Dananji mentioned this pull request Dec 16, 2024
Closed
@Dananji Dananji changed the title External annotationpage Parse annotations from linked external AnnotationPage(s) Dec 16, 2024
cjcolvar
cjcolvar reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking like a good foundation. I'm looking forward to the next steps where these annotations will surface in the UI.

src/services/annotations-parser.js Outdated Show resolved Hide resolved
src/services/annotations-parser.js Show resolved Hide resolved
@Dananji Dananji merged commit a959b41 into main Dec 17, 2024
2 checks passed
@Dananji Dananji deleted the external-annotationpage branch December 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar