better handling for error cases in FileMetadata.find #5706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
valkyrie-file-find
branch
from
2d17b97 to
fb8c75d
Compare
dunn
previously approved these changes
Jun 16, 2022
no-reply
force-pushed
the
valkyrie-file-find
branch
from
fb8c75d to
35e38a9
Compare
the base case originally tested relied on a bug in Valkyrie (samvera/valkyrie#905). this reimplements with a more serious error handling approach.
dunn
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the base case originally tested relied on a bug in
Valkyrie (samvera/valkyrie#905).
this reimplements with a more serious error handling approach.
@samvera/hyrax-code-reviewers