StorageAdapter Versioning Implementation #932
Conversation
Co-authored-by: Anna Headley <[email protected]>
tpendragon
force-pushed
the
storage_versioning
branch
from
c07b4c1 to
97f979f
Compare
|
|
||
| def upload_version(id:, file:) | ||
| version_timestamp = current_timestamp | ||
| version_id = version_id(id) |
There was a problem hiding this comment.
might be nice to name the local variable different from the method
There was a problem hiding this comment.
Maybe comment why we're getting this? It seems like it's the version id of the file that, before this new file is uploaded, is the current version. And that it's used to get/create the correct file path for the file we're about to upload.
Co-authored-by: hackartisan <[email protected]>
Co-authored-by: hackartisan <[email protected]>
Co-authored-by: hackartisan <[email protected]>
| end | ||
|
|
||
| def current_timestamp | ||
| Time.now.strftime("%s%N") |
There was a problem hiding this comment.
Would milliseconds (%L) be good enough here? It would save 6 characters in every filename.
There was a problem hiding this comment.
Apparently not, one of the tests fails. Computer's too fast. 😎
There was a problem hiding this comment.
I could re-call if the file already exists, probably a good safety measure.
tpendragon
force-pushed
the
storage_versioning
branch
from
b7a73e8 to
54b5dad
Compare
|
|
||
| # Delete the file on disk associated with the given identifier. | ||
| # @param id [Valkyrie::ID] | ||
| def delete(id:, purge_versions: false) |
There was a problem hiding this comment.
purge_versions no longer used
There was a problem hiding this comment.
Good catch, removed.
This adds a versioning implementation to Valkyrie StorageAdapters and implements it for a new versioned disk adapter and Fedora 4/5/6.
There's a follow-on ticket to do here: #934
As this doesn't change the API or outcomes of any of the adapters this is a minor release.