Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of the inline powerbox #1398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jparyani
Copy link
Collaborator

It's still a bit rough around the edges, but the basic functionality
works.

It's still a bit rough around the edges, but the basic functionality
works.
.assert.containsText("#request-result", "successfully fetched page");
};

module.exports["Install Faling Inline Powerbox"] = function (browser) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Faling/Failing/

@ocdtrekkie ocdtrekkie added the app-platform App/Sandstorm integration features label Jan 16, 2020
@ocdtrekkie
Copy link
Collaborator

What is this PR in comparison to Sandstorm today, @zenhack? Should this be closed?

@zenhack
Copy link
Collaborator

zenhack commented Feb 9, 2020

It looks like this is a slightly different feature/design than what sandstorm currently has; if I'm reading the code correctly it shows an input just below the bottom of the grain frame, instead of a modal dialog floating over it. What I don't know is what the intent was here -- were folks expecting to have both UIs for some reason, or is this just obsolete? Is there a design doc somewhere?

@kentonv, any thoughts?

@kentonv
Copy link
Member

kentonv commented Feb 15, 2020

The "inline powerbox" refers to the "autocomplete style" powerbox UI described in the roadmap.

I do think this style of powerbox is important in the long term. Many kinds of everyday interactions -- such as selecting recipients of an e-mail -- become cumbersome with a full powerbox, but could be made to feel almost normal using the inline powerbox, without sacrificing security.

However, implementing the inline powerbox is pretty hairy, since it requires communication between the app and the shell to capture keystrokes and decide where to render the overlay. I think we should focus on lower-hanging fruit for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-platform App/Sandstorm integration features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants