Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.0 #39

Merged
merged 67 commits into from
Apr 18, 2024
Merged

Release 0.10.0 #39

merged 67 commits into from
Apr 18, 2024

Conversation

ksenia-krasheninnikova
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Apr 16, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0276f81

+| ✅ 129 tests passed       |+
#| ❔  19 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • nextflow_config - Config manifest.version should end in dev: '0.9.1'
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-genomeassembly_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genomeassembly_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genomeassembly_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-genomeassembly_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genomeassembly_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genomeassembly_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/genomeassembly/genomeassembly/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2024-04-16 14:37:24

@gq1
Copy link
Member

gq1 commented Apr 16, 2024

I suppose everything will be fine. But can you wait the CI job finish on the farm and then merge.
https://cloud.seqera.io/orgs/sanger-tol/workspaces/github-ci/watch/4SysMj4aWWxqFm

Being pending over 30mins now.

gq2@tol-head1:~$ bjobs -w 9361938
JOBID   USER    STAT  QUEUE      FROM_HOST   EXEC_HOST   JOB_NAME   SUBMIT_TIME
9361938 toldev  PEND  oversubscribed tol-head2      -        nf-workflow-4SysMj4aWWxqFm Apr 16 15:34

@ksenia-krasheninnikova
Copy link
Contributor Author

@gq1 @muffato The github CI checks are fine, I'm happy to merge as long as get an approval. Thanks :)

@gq1
Copy link
Member

gq1 commented Apr 16, 2024

The CI job only submit the job on farm, not sure why pending so long. This is the first time you run all the code together on dev, better to wait.

@ksenia-krasheninnikova ksenia-krasheninnikova merged commit 31b508a into main Apr 18, 2024
22 checks passed
ksenia-krasheninnikova added a commit that referenced this pull request Apr 18, 2024
Merge pull request #39 from sanger-tol/dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants