Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some github api calls response header from http 1.1 to 1.0 #71

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Update some github api calls response header from http 1.1 to 1.0 #71

merged 2 commits into from
Jul 4, 2024

Conversation

gq1
Copy link
Member

@gq1 gq1 commented Jul 4, 2024 •
edited
Loading

  1. Most GitHub API call from PHP using request with Authorization: Basic , which response header will change to HTTP/1.0
  2. When request without authorization set, like in launch page, the response header not changed, still HTTP/1.1. But sometimes may get HTTP/1.1 403.
  3. Tried Github API query using other methods, normally response with HTTP/2.

@gq1 gq1 self-assigned this Jul 4, 2024
@gq1 gq1 requested a review from muffato July 4, 2024 13:29
muffato
muffato approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that all HTTP/1.1 from GitHub have been changed to HTTP/1.0 in this PR

@gq1 gq1 merged commit d1eedd5 into main Jul 4, 2024
3 checks passed
@gq1 gq1 deleted the http_header branch July 4, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muffato muffato muffato approved these changes

Assignees

@gq1 gq1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gq1 @muffato