-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ausbeth reinstall #1
Conversation
…ity-hpc into ausbeth-test
…essage user friendly
Also adding flaggers for reinstall (complete and all)
shpc reinstall software # reinstall all installed versions of that software (achieved) By default, shpc reinstall software will keep the current container of that software. User can type --complete flagger to override that: Note - User cannot type:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ausbeth . Here are some comments on your code, mainly going into two categories:
- the current implementation
- options/modes we haven't talked much about so far, like views, container paths, etc.
…ng code structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost nothing left from me. Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Ausbeth for those changes 👍🏼 .
pytest works for me locally, but I only run tcl and singularity. There seems to be an error on GitHub CI. Can you take a look ? That's the only reason why I'm not approving the PR yet
Hi @muffato, yes, the issue is that the tests are not working with podman for some reason. I have been trying to solve it, but I don't know how to at the moment |
making comment clearer Co-authored-by: Matthieu Muffato <[email protected]>
reinstall functionality