Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop-rspec 3.4.0 → 3.5.0 (minor) #562

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update rubocop-rspec 3.4.0 → 3.5.0 (minor) #562

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Feb 18, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (3.4.0 → 3.5.0) · Repo · Changelog

Release Notes

3.5.0

  • Don't let RSpec/PredicateMatcher replace respond_to? with two arguments with the RSpec respond_to matcher. (@bquorning)
  • Fix RSpec/PredicateMatcher support for eql and equal matchers. (@bquorning)
  • Pluginfy RuboCop RSpec. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 37 commits:

✳️ rubocop (1.71.1 → 1.72.2) · Repo · Changelog

Release Notes

1.72.2

Bug fixes

  • #13853: Fix exclusion of relative paths in plugin's AllCops: Exclude as expected. (@koic)
  • #13844: Fix an error for Style/RedundantFormat when a template argument is used without keyword arguments. (@koic)
  • #13857: Fix an error for Style/RedundantFormat when numeric placeholders is used in the template argument. (@koic)
  • #13861: Fix ArgumentError related to two deprecated AllowedPattern APIs. (@koic)
  • #13849: Fix an error for Lint/UselessConstantScoping when multiple assigning to constants after private access modifier. (@koic)
  • #13856: Fix false positives for Lint/UselessConstantScoping when a constant is used after private access modifier with arguments. (@koic)

Changes

  • #13846: Mark Style/RedundantFormat as unsafe autocorrect. (@koic)

1.72.1

Bug fixes

  • #13836: Fix an error for Style/RedundantParentheses when a different expression appears before a range literal. (@koic)
  • #13839: Fix false positives for Lint/RedundantTypeConversion when passing block arguments when generating a Hash or a Set. (@koic)

Changes

  • #13839: Extension plugin is loaded automatically with require 'rubocop/rspec/support'. (@koic)

1.72.0

New features

  • #13740: Add new Lint/CopDirectiveSyntax cop. (@kyanagi)
  • #13800: Add new Lint/SuppressedExceptionInNumberConversion cop. (@koic)
  • #13702: Add new Lint/RedundantTypeConversion cop. (@dvandersluis)
  • #13831: Add new Lint/UselessConstantScoping cop. (@koic)
  • #13793: Add new Style/RedundantFormat cop to check for uses of format or sprintf with only a single string argument. (@dvandersluis)
  • #13581: Add new InternalAffairs/LocationExists cop to check for code that can be replaced with Node#loc? or Node#loc_is?. (@dvandersluis)
  • #13661: Make server mode detect local paths in .rubocop.yml under inherit_from and require for automatically restart. (@koic)
  • #13721: Naming/PredicateName: Optionally use Sorbet to detect predicate methods. (@issyl0)
  • #6012: Support RuboCop extension plugin. (@koic)

Bug fixes

  • #13807: Fix false negatives for Style/RedundantParentheses when chaining [] method calls. (@koic)
  • #13788: Fix false negatives for Style/RedundantParentheses when [] method is called with variable or constant receivers. (@koic)
  • #13811: Fix false negatives for Style/RedundantParentheses when handling range literals with redundant parentheses. (@koic)
  • #13796: Fix crash in Layout/EmptyLinesAroundMethodBody for endless methods. (@dvandersluis)
  • #13817: Fix false positive for format specifier with non-numeric precision. (@dvandersluis)
  • #12672: Fix false positives for Lint/FormatParameterMismatch when the width value is interpolated. (@dvandersluis)
  • #12795: Fix Layout/BlockAlignment for blocks that are the body of an endless method. (@dvandersluis)
  • #13822: Fix undefined method Logger when processing watched file notifications. (@vinistock)
  • #13805: Make the language_server-protocol dependency version stricter. (@koic)

1.71.2

Bug fixes

  • #13782: Fix an error Layout/ElseAlignment when else is part of a numblock. (@earlopain)
  • #13395: Fix a false positive for Lint/UselessAssignment when assigning in branch and block. (@pCosta99)
  • #13783: Fix a false positive for Lint/Void when each numblock with conditional expressions that has multiple statements. (@earlopain)
  • #13787: Fix incorrect autocorrect for Style/ExplicitBlockArgument when using arguments of zsuper in method definition. (@koic)
  • #13785: Fix Style/EachWithObject cop error in case of single block argument. (@viralpraxis)
  • #13781: Fix a false positive for Lint/UnmodifiedReduceAccumulator when omitting the accumulator in a nested numblock. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.9.1 → 2.10.1) · Repo · Changelog

Release Notes

2.10.1 (from changelog)

  • Fix a compatibility issue with MultiJson.dump(obj, pretty: true): no implicit conversion of false into Proc (TypeError).

2.10.0

What's Changed

  • strict: true now accept symbols as values. Previously they'd only be accepted as hash keys.
  • The C extension Parser has been entirely reimplemented from scratch.
  • Introduced JSON::Coder as a new API allowing to customize how non native types are serialized in a non-global way.
  • Introduced JSON::Fragment to allow assembling cached fragments in a safe way.
  • The Java implementation of the generator received many optimizations.

Full Changelog: v2.9.1...v2.10.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 61 commits:

↗️ parser (indirect, 3.3.7.0 → 3.3.7.1) · Repo · Changelog

Release Notes

3.3.7.1 (from changelog)

API modifications:

  • parser/current: add -dev prefix to 3.4 branch (#1067) (Ilya Bylich)
  • parser/current: bump 3.2 branch to 3.2.7 (#1066) (Ilya Bylich)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:

🆕 lint_roller (added, 1.1.0)

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added dependencies Pull requests that update a dependency file Technical Debt labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants