Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y25-002 - [BUG] Duplicate Samples per Pool validations for scRNA cDNA Prep Submission #4579

Open
2 tasks
yoldas opened this issue Jan 3, 2025 · 3 comments · May be fixed by #4638
Open
2 tasks

Y25-002 - [BUG] Duplicate Samples per Pool validations for scRNA cDNA Prep Submission #4579

yoldas opened this issue Jan 3, 2025 · 3 comments · May be fixed by #4638
Assignees
Labels
Bug Bug in code scRNA - cDNA prep scRNA Size: S Small - low effort & risk

Comments

@yoldas
Copy link
Member

yoldas commented Jan 3, 2025

Describe the bug
Both of the stories below implement the "Sample per Pool" validation for scRNA cDNA Prep Submission with different error messages. Pool sizes for a study-project are found by the division number_of_samples / number_of_pools. The size of some of the pools (or all) will be equal to the quotient. The size of some of the pools will be the quotient plus one if there is a remainder.

  • Y24-402 - Specify 'no. pools' rather than 'no. samples per pool' in submission Y24-402 - Specify 'no. pools' rather than 'no. samples per pool' in submission #4423
    Excerpt from acceptance criteria: "Number of samples per pool' (to be calculated - see additional context) must be between 5 and 25 (inclusive)"
    Error messages:
    There is a separate error message for each possible pool. They are numbered as pool number 1, pool number 2, pool number 3, and so on.
    Comments:
    There is no need to check the range and repeat the same error for each possible pool. There are only two possible sizes (quotient and quotient plus one), independent of how many pools there are (one to eight).
    The number of error messages can be as high as 8 while only the "pool number" is different in them.
    Screenshot: See the red rectangle below

  • Y24-429 - Check feasibility of cDNA Prep submission Y24-429 - Check feasibility of cDNA Prep submission #4460
    Excerpt from acceptance criteria: "The number of pools requested must be feasible given the number of samples"
    Error messages:
    There is a separate error message only for the smallest and biggest pools. If the smallest and biggest pools are the same or the number_of_pools is one, the error is reported only for the smallest pool.
    Comments:
    Only the smallest and biggest pools sizes are checked and reported.
    Screenshot: See the blue rectangle below

The following screenshot shows an example when the number of samples is 10 and number of pools is 3.

number_of_samples/number_of_pools = 10/3
Quotient = 3
Remainder = 1
Pool sizes: 3, 3, 4
Smallest pool size: 3
Biggest pool size: 4

Screenshot 2025-01-03 at 00 59 42

RT Ticket Number
N/A

To Reproduce
Steps to reproduce the behaviour:
See the notes for manual testing at #4460 (comment) .
Change the number of pools in the spreadsheet to make the quotient of the division number_of_samples / number_of_pools or the quotient plus one outside of the range 5 to 25.

Expected behaviour

  • Remove the duplicated validation of the same condition.
  • Provide concise error messages to help user.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
N/A

Additional context
Add any other context about the problem here.

@psd-issuer psd-issuer bot changed the title [BUG] Duplicate Samples per Pool validations for scRNA cDNA Prep Submission Y25-002 - [BUG] Duplicate Samples per Pool validations for scRNA cDNA Prep Submission Jan 3, 2025
@andrewsparkes
Copy link
Member

For those error messages if you do refer to a pool number I'd make it display the pool numbers starting from 1 (i.e. 1-8) rather than the internal zero based index (i.e. add +1 for the messages).

@yoldas
Copy link
Member Author

yoldas commented Jan 3, 2025

@andrewsparkes I agree that they should start with one if that validation stays. I think it should go away (red rectangle in the screenshot) . Pool numbering don't match the reality and there is no way to check a specific pool. Identification by number does not look right to me.

I think the messages in blue rectangle in the screenshot are better. Maybe they can be improved by replacing the word found with calculated.

@yoldas yoldas added scRNA Size: S Small - low effort & risk labels Jan 3, 2025
@KatyTaylor
Copy link
Contributor

Agreed I prefer the messages in the blue rectangle.

@wendyyang wendyyang self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug in code scRNA - cDNA prep scRNA Size: S Small - low effort & risk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants