4579-y25-002---bug-duplicate-samples-per-pool-validations #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yoldas
requested changes
Jan 28, 2025
| number_of_pools = rows.pluck(headers.index(HEADER_NUMBER_OF_POOLS)).uniq.first.to_i | ||
|
|
||
| validate_samples_per_pool(rows, total_number_of_samples_per_study_project, number_of_pools) | ||
| nil if plate.nil? | ||
| end |
There was a problem hiding this comment.
validate_for_plates is not doing any validation. What is the purpose of it?
|
|
||
| validate_samples_per_pool(rows, total_number_of_samples_per_study_project, number_of_pools) | ||
| def validate_for_tubes(barcodes) | ||
| find_tubes(barcodes) | ||
| end |
There was a problem hiding this comment.
validate_for_tubes is not doing any validation. What is the purpose of it?
| @@ -3,7 +3,6 @@ | |||
| <strong>none</strong> of them will be processed. You will get feedback about any problems.</p> | |||
| <% end %> | |||
| <%= semantic_form_for @bulk_submission, html: { multipart: true } do |form| %> | |||
| <%= form.semantic_errors :base %> | |||
There was a problem hiding this comment.
Note: This removes the duplicate listing of the same error messages at the form level because they are already listed at the input control level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
remove duplicate validation
remove duplicate error messages display
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version