Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-382: Improve clarity of cherrypicking strategies and values #4544

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bf86e6f
refactor: make it clear which option belongs to which strategy
StephenHulme Dec 4, 2024
469398b
refactor: cherrypicking_volume_parameters -> cherrypicking_parameters
StephenHulme Dec 4, 2024
a63e86d
feat: highlight strategy card on selection
StephenHulme Dec 5, 2024
9cc9e16
refactor: move javascript code into dedicated script file
StephenHulme Dec 5, 2024
208fd63
refactor: rename cherrypicking partials
StephenHulme Dec 13, 2024
478c39c
Merge branch 'develop' into y24-382-refactor-cherrypicking-strategies
StephenHulme Jan 27, 2025
f472384
refactor: replace custom field_id with railsy method
StephenHulme Jan 28, 2025
fb6f7fe
refactor: rename action -> strategy
StephenHulme Jan 28, 2025
fcf7e69
style: add docstring to form group radio
StephenHulme Jan 28, 2025
cf88d98
fix: rename action -> strategy
StephenHulme Jan 28, 2025
98f28e6
Merge branch 'develop' into y24-382-refactor-cherrypicking-strategies
StephenHulme Jan 28, 2025
0446451
test: provide more specific references to fields
StephenHulme Jan 29, 2025
8ef7657
fix: set per-pipeline default volumes
StephenHulme Jan 29, 2025
f010b1a
fix: rename action -> strategy
StephenHulme Jan 29, 2025
2ef627a
Merge branch 'develop' into y24-382-refactor-cherrypicking-strategies
StephenHulme Jan 29, 2025
dd18d68
test: fix broken tests
StephenHulme Jan 29, 2025
7a9aefa
refactor: repair forms to maintain consistency between workflow stages
StephenHulme Feb 12, 2025
14401ac
refactor: use form helpers to generate fields
StephenHulme Feb 13, 2025
f80c787
fix: remove unneeded volume_required prefixes
StephenHulme Feb 14, 2025
2d554a9
fix: label typo
StephenHulme Feb 14, 2025
2a89290
fix: remove lingering form references
StephenHulme Feb 14, 2025
52bde00
Merge branch 'develop' into y24-382-refactor-cherrypicking-strategies
StephenHulme Feb 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into y24-382-refactor-cherrypicking-strategies
StephenHulme committed Jan 27, 2025
commit 478c39cc086384be1e9ef768e11e6f3c752a3510

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.