Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-213 - Removed default_includes from v2 API Resources #4635

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

SHIV5T3R
Copy link
Member

Closes #4233

Changes proposed in this pull request

  • Removed underlying support and all references to default_includes because it is no longer required.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (10bf7bb) to head (72a36b4).
Report is 32 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4635      +/-   ##
===========================================
- Coverage    89.42%   89.41%   -0.02%     
===========================================
  Files         1406     1406              
  Lines        30298    30249      -49     
===========================================
- Hits         27095    27048      -47     
+ Misses        3203     3201       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dasunpubudumal dasunpubudumal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We need to make sure that the JSONAPI responses haven't been affected by removing this. How do we test it? Is it through the integration suite or do we plan to manually test the endpoints pertaining to these resources?

@SHIV5T3R
Copy link
Member Author

Nice. We need to make sure that the JSONAPI responses haven't been affected by removing this. How do we test it? Is it through the integration suite or do we plan to manually test the endpoints pertaining to these resources?

Just finished testing, there's one response that has changed, but it's very insignificant. I can give some extra info, but it was just one tag group where the order of the tags was slightly changed because of duplicate indexes. It's hard to tell if it's a problem with the code or not, because it persists throughout different environments. Aside from that, it should be ready to deploy to UAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-213 - Remove use of default_includes in API v2 resources and the underlying support for it
3 participants