adding a new operation visium QC operation : qPcr results #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seenanair
reviewed
Jan 25, 2024
| setTouched({}); | ||
| const measurements = values?.slotMeasurements ? [...values.slotMeasurements] : []; | ||
| measurements | ||
| ?.filter((measurement) => measurement.name === measurementName) |
There was a problem hiding this comment.
Why we need to filter it? I thougt we only have one measurement (Cq value) here? or Is it for future additions?
| (values.qcType === QCType.CDNA_AMPLIFICATION && values.slotMeasurements) | ||
| ) { | ||
| sendCDNA({ | ||
| type: 'SUBMIT_FORM', | ||
| values: { | ||
| workNumber: values.workNumber, | ||
| barcode: values.barcode, | ||
| slotMeasurements: values.slotMeasurements ?? [], | ||
| slotMeasurements: values.slotMeasurements?.map(({ samples, ...rest }) => rest) ?? [], |
There was a problem hiding this comment.
Are we getting rid of 'samples' field? if so, why?
There was a problem hiding this comment.
yes, because we don't need in the request, we are just adding some info in the display. also the GraphQL request will fail if we pass the wrong arguments .
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Couldn't find a test case when there is server error.
seenanair
approved these changes
Jan 25, 2024
|
merged to devel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.