Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop 1.72.2 → 1.73.0 (minor) #742

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Feb 27, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.72.2 → 1.73.0) · Repo · Changelog

Release Notes

1.73.0

New features

  • #11024: Add require_always option to Style/EndlessMethod. (@koic)
  • #11024: Add require_single_line option to Style/EndlessMethod. (@jtannas)
  • #9935: Introduce EnforcedStyleForMultiline "diff_comma". (@flavorjones)

Bug fixes

  • #13867: Fix an error for plugins when not running RuboCop through Bundler. (@earlopain)
  • #13902: Fix false negative for Style/RedundantSelfAssignment when the method receives a block. (@vlad-pisanov)
  • #13826: Fix false positives for regex cops when Lint/MixedCaseRange is enabled. (@earlopain)
  • #13818: Fix false positives for Lint/Void when using operator method call without argument. (@koic)
  • #13896: Fix a false positive for Style/TrivialAccessors with instance_eval and numblocks. (@earlopain)
  • #13910: Fix false positives for Style/EndlessMethod when using setter method definitions. (@koic)
  • #13889: Fix autocorrection for Layout/LineLength with interpolated strings when not on the first line. (@dvandersluis)
  • #13900: Fix infinite loop between Layout/EmptyLinesAroundAccessModifier and Layout/EmptyLinesAroundBlockBody with EnforcedStyle: no_empty_lines. (@dvandersluis)
  • #12692: Fix Style/AccessorGrouping with constants. (@tejasbubane)
  • #13882: Fix Style/RedundantFormat for annotated template strings with missing hash keys. (@dvandersluis)
  • #13880: Fix Style/RedundantFormat when given double-splatted arguments. (@dvandersluis)
  • #13907: Don't offer autocorrect for Style/StringConcatenation when numblocks are used. (@earlopain)
  • #13876: Don't consider require 'pp' to be redundant for Lint/RedundantRequireStatement. (@earlopain)
  • #13885: Update Style/HashExcept and Style/HashSlice to not register an offense if selecting over the hash value. (@dvandersluis)

Changes

  • #12948: Add ForbiddenNames configuration to Naming/VariableName to specify names that are forbidden. (@dvandersluis)
  • #13117: Add partial autocorrect support to Lint/LiteralAsCondition cop to check for redundant conditions. (@zopolis4)
  • #13892: Allow merging of configured arrays and non-arrays. (@sambostock)
  • #13833: Add Reference to common params. (@sambostock)
  • #13890: Update Lint/RedundantTypeConversion to not register an offense when given a constructor with exception: false. (@dvandersluis)
  • #13729: Update Style/RedundantCondition cop to detect conditional expressions where the true branch is true and suggest replacing them with a logical OR. (@datpmt)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 58 commits:

↗️ rubocop-ast (indirect, 1.38.0 → 1.38.1) · Repo · Changelog

Release Notes

1.38.1 (from changelog)

Bug fixes

  • #360: Fix an error when the Array core class contains a writer method before rubocop-ast loaded. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added dependencies Pull requests that update a dependency file Technical Debt Technical Debt labels Feb 27, 2025
Copy link
Contributor Author

depfu bot commented Feb 28, 2025

Closed in favor of #743.

@depfu depfu bot closed this Feb 28, 2025
@depfu depfu bot deleted the depfu/update/rubocop-1.73.0 branch February 28, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Technical Debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants