feat(listener): add support for includeAllVersions #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
commented
Feb 5, 2025
| * Whether to include events for drafts and versions. As of API Version >= v[TBD], only events | ||
| * for published documents will be included by default. | ||
| * If you need events from drafts and versions, set this to `true`. | ||
| * Note: Keep in mind that additional document variants may be introduced in the future, so it's |
There was a problem hiding this comment.
this assumes parity with perspective=raw, but given that the param is explicitly named includeAllVersions, I guess in theory we could introduce new variants in the future without including them behind this flag.
There was a problem hiding this comment.
Right, that is possible. We'll have to consider any further developments in this area very carefully.
bjoerge
force-pushed
the
add-include-all-version-param
branch
from
d0a143f to
20a44bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR to prepare for an upcoming change