Reintroduce BDInterface.get_for_vrf() #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the heat of cleaning up the old BDI code and for that matter not needing to parameterize all the get_item/get_filter calls we also accidentally removed the get_for_vrf() call. This might result in that in some cases we don't clean up interfaces properly. This happens on router delete and the exception is caught, so the DeviceCleaner should remove any left over interfaces, but reintroducing the original method is of course the way to go. By readding get_for_vrf() we no longer see an exception on router delete and everything should get cleaned up properly.
mutax
approved these changes
Jan 9, 2025
rhalina
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the heat of cleaning up the old BDI code and for that matter not needing to parameterize all the get_item/get_filter calls we also accidentally removed the get_for_vrf() call. This might result in that in some cases we don't clean up interfaces properly. This happens on router delete and the exception is caught, so the DeviceCleaner should remove any left over interfaces, but reintroducing the original method is of course the way to go.
By readding get_for_vrf() we no longer see an exception on router delete and everything should get cleaned up properly.