Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bedrock): adjustments for bedrock #1459

Merged
merged 13 commits into from
Nov 15, 2024
Merged

feat(bedrock): adjustments for bedrock #1459

merged 13 commits into from
Nov 15, 2024

Conversation

hgw77
Copy link
Collaborator

@hgw77 hgw77 commented Nov 12, 2024

Summary

  • fix for edit project, now we moved edit project out of masterdata into identity where it belongs to

  • fix for check for cidr range

  • do not show internal docu links if documentation should be hidden

  • render internal or external links based on the config

  • adjust the hint on network creation to address the IP range for bedrock domains

Related Issues

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! 👍

@andypf andypf marked this pull request as ready for review November 15, 2024 15:04
@andypf andypf merged commit cb668b4 into master Nov 15, 2024
4 checks passed
@andypf andypf deleted the hgw-bedrock branch November 15, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants