Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Commit

Permalink
fix release page use long commitish (gardenlinux#2143)
Browse files Browse the repository at this point in the history
* fix: release note generation use long commitish for github api

* refactor variable name and format output of kmod container section
  • Loading branch information
Vincinator authored Jun 14, 2024
1 parent 2146280 commit 85ba142
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-page.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
.github/workflows/release_note.py create --tag ${{ inputs.version }} --commit "$(echo "${{ inputs.commit }}" | cut -c -8)"
.github/workflows/release_note.py create --tag ${{ inputs.version }} --commit "$(echo "${{ inputs.commit }}")"
- uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # pin@v3
with:
name: release
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/release_note.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,10 @@ def generate_package_update_section(version):


def create_github_release_notes(gardenlinux_version, commitish):
commitish_short=commitish[:8]
output = ""

manifests = download_all_singles(gardenlinux_version, commitish)
manifests = download_all_singles(gardenlinux_version, commitish_short)

output += generate_release_note_image_ids(manifests)

Expand All @@ -220,13 +221,17 @@ def create_github_release_notes(gardenlinux_version, commitish):
output += get_kernel_urls(gardenlinux_version)
output += "\n"

output += generate_image_download_section(manifests, gardenlinux_version, commitish )
output += generate_image_download_section(manifests, gardenlinux_version, commitish_short )

output += "\n"
output += "## Kernel Module Build Container (kmodbuild)"
output += "````"
output += "## Kernel Module Build Container (kmodbuild) "
output += "\n"
output += "```"
output += "\n"
output += f"ghcr.io/gardenlinux/kmodbuild:{gardenlinux_version}"
output += "\n"
output += "```"
output += "\n"
return output

def write_to_release_id_file(release_id):
Expand Down

0 comments on commit 85ba142

Please sign in to comment.