Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memcached] version bumped to 1.6.31-alpine3.20 #7247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

businessbean
Copy link
Contributor

@businessbean businessbean commented Oct 15, 2024

  • Memcached 1.6.31 Release Notes
  • added alpine version tag to enforce exactly this version
  • version info added to labels
    • to allow gatekeeper rules based on them
  • old (non-standard) labels removed
  • chart version bumped

label example

labels:
  app.kubernetes.io/name: memcached
  app.kubernetes.io/instance: keystone-memcached
  app.kubernetes.io/component: memcached-deployment-kvstore
  app.kubernetes.io/part-of: keystone
  app.kubernetes.io/version: 1.6.31
  app.kubernetes.io/managed-by: "helm"
  helm.sh/chart: memcached-0.6.0

removed labels

labels:
   app: keystone-memcached
   component: memcached
   chart: "memcached-0.5.3"
   release: "keystone"
   heritage: "Helm"
   type: configuration
   application: keystone

Copy link
Contributor

@s10 s10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Such custom labels as system and type are present everywhere, but aren't being used anywhere.
application and component label is being used in helm-toolkit.snippets.kubernetes_metadata_labels helper, but has no meaning here.

@s10 s10 self-requested a review October 29, 2024 12:11
- added alpine version to the tag to enforce exactly this version
- version info added to labels to allow gatekeeper rules based on them
- label names in alert expressions updated
- old (non-standard) labels removed
- chart version bumped

Signed-off-by: Birk Bohne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants