Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/openstack: use more compact serialization for Keystone tokens #452

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

majewsky
Copy link
Contributor

@majewsky majewsky commented Nov 5, 2024

Since the new format should have all redundancies eliminated from it, I figure that the roundtrip through gzip and base64 is not going to save much space (or could actually waste bytes if gzip cannot save more than the 33% that base64 adds). In any case, it's more computationally expensive, so I'm getting rid of it.

Since the new format should have all redundancies eliminated from it,
I figure that the roundtrip through gzip and base64 is not going to
save much space (or could actually waste bytes if gzip cannot save more
than the 33% that base64 adds). In any case, it's more computationally
expensive, so I'm getting rid of it.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have benchmarks, do we?

@coveralls
Copy link

Coverage Status

coverage: 80.221% (-0.04%) from 80.265%
when pulling 9e07c4e on keystone-compact-tokens
into de0ba0a on master.

@majewsky
Copy link
Contributor Author

majewsky commented Nov 5, 2024

We don't have benchmarks, do we?

Not in the automated sense, no. Running a benchmark on this (in the https://pkg.go.dev/testing sense) would require instantiating the Keystone AuthPlugin, which would require having an OpenStack in scope for the tests. I will have a look at the CPU/RAM usage metrics after this is merged.

@majewsky majewsky merged commit d4a4981 into master Nov 5, 2024
7 checks passed
@majewsky majewsky deleted the keystone-compact-tokens branch November 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants