vmware: Encrypt vmotion if flavor requires it, or don't #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandchild
force-pushed
the
i533984/vmotion_encryption
branch
3 times, most recently
from
d573031 to
1b6d1ac
Compare
grandchild
force-pushed
the
i533984/vmotion_encryption
branch
2 times, most recently
from
5ba9ba5 to
61f8012
Compare
Vmotions should be encrypted, but not for really large RAM sizes because encryption impacts vmotion performance too much. Let the flavor define one of "required", "disabled" or "opportunistic". The default in our VMware configuration is "opportunistic", which means "use encryption for the vmotion if both source and target support it", which should be all of our landscape. We default to "required" explicitly now in Nova for every new & resized general- purpose-flavored VM. If the flavor sets an invalid value, the default will be used and a warning logged. Change-Id: Iba0fd2f2edc8fae210f6c4bab0218703e87ecfbc
grandchild
force-pushed
the
i533984/vmotion_encryption
branch
from
61f8012 to
200af10
Compare
|
Rebased onto stable/xena-m3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vmotions should be encrypted, but not for really large RAM sizes because encryption impacts vmotion performance too much. So let the flavor define one of "required", "disabled" or "opportunistic". If not set, null/None defaults to "opportunistic".
Change-Id: Iba0fd2f2edc8fae210f6c4bab0218703e87ecfbc