SAP: Use is_instance_storage_share instead of ssh #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative to #513. This one changes the |
The libvirt-driver implements is_instance_storage_share twice: Once on driver-internally as `_is_path_shared_with` needing an ssh trust, and via the driver interface `is_instance_storage_share`, relying on RPC. By moving exposing `is_instance_storage_share` in ComputeVirtAPI, the driver can use this instead of the internal method removing the need for an SSH key in case of having a shared storage. But since it requires a change of the driver internal API, it is questionable if we can upstream the change as it is. Change-Id: Icddad1ab000ea07dea7af3aa5f7c18974f4eb8fb
fwiesel
force-pushed
the
pass_migration_to_resize
branch
from
58c98db to
06ed4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libvirt-driver implements is_instance_storage_share twice: Once on driver-internally as
_is_path_shared_withneeding an ssh trust, and via the driver interfaceis_instance_storage_share, relying on RPC.By moving exposing
is_instance_storage_sharein ComputeVirtAPI, the driver can use this instead of the internal method removing the need for an SSH key in case of having a shared storage.But since it requires a change of the driver internal API, it is questionable if we can upstream the change as it is.
Change-Id: Icddad1ab000ea07dea7af3aa5f7c18974f4eb8fb