Skip to content

Commit

Permalink
[as3/tenant] raise error on any exception, including barbican
Browse files Browse the repository at this point in the history
retry instead skip listener
  • Loading branch information
notandy committed Jun 6, 2024
1 parent fbf0785 commit 13d1cfc
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions octavia_f5/restclient/as3objects/tenant.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from oslo_log import log as logging

from octavia_lib.common import constants as lib_consts
from octavia.common import exceptions as o_exceptions
from octavia_f5.common import constants
from octavia_f5.restclient import as3classes as as3
from octavia_f5.restclient.as3classes import Application
Expand Down Expand Up @@ -62,18 +61,8 @@ def get_tenant(segmentation_id, loadbalancers, self_ips, status_manager, cert_ma
# Attach Octavia listeners as AS3 service objects
for listener in loadbalancer.listeners:
if not driver_utils.pending_delete(listener):
try:
service_entities = m_service.get_service(listener, cert_manager, esd_repo)
app.add_entities(service_entities)
except o_exceptions.CertificateRetrievalException as e:
if getattr(e, 'status_code', 0) != 400:
# Error connecting to keystore, skip tenant update
raise e

LOG.error("Could not retrieve certificate, assuming it is deleted, skipping listener '%s': %s", listener.id, e)
if status_manager:
# Key / Container not found in keystore
status_manager.set_error(listener)
service_entities = m_service.get_service(listener, cert_manager, esd_repo)
app.add_entities(service_entities)

# Attach pools
for pool in loadbalancer.pools:
Expand Down

0 comments on commit 13d1cfc

Please sign in to comment.