Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEBUG print status #267

Merged
merged 8 commits into from
May 6, 2024
Merged

Add DEBUG print status #267

merged 8 commits into from
May 6, 2024

Conversation

velp
Copy link
Contributor

@velp velp commented May 6, 2024

I could not reproduce the issue in QA, so I added more error handlers and debug messages to catch the situation.
This PR adds:

  • additional error handler for empty response
  • additional error handler for response less than 2 devices
  • more information if the status request failed
  • additional check if both devices are BACKUP
  • if both devices are not active we do not update the status in the cache and keep the current status

Related to octavia-issues#28

@velp velp requested a review from m-kratochvil May 6, 2024 14:04
Copy link
Contributor

@m-kratochvil m-kratochvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is failing but beside that the change looks ok, approved

@velp velp merged commit f5dcdff into stable/yoga-m3 May 6, 2024
3 checks passed
@velp velp deleted the debug_backup_status branch May 6, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants