Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for session mirroring configured on TCP listeners. #274

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

velp
Copy link
Contributor

@velp velp commented Jul 17, 2024

This pull request implements a custom tag ccloud_special_tcp_mirror for supporting session mirroring on TCP listeners. Because we are using Service_TCP for both listener protocols TCP and HTTPS we check listener.protocol instead of _servicetype to avoid HTTPS listeners enabled with mirroring.

Related to Issue #42 and Enhancement #153

Copy link
Contributor

@m-kratochvil m-kratochvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@BenjaminLudwigSAP BenjaminLudwigSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thx

@BenjaminLudwigSAP BenjaminLudwigSAP merged commit eef9a77 into stable/yoga-m3 Jul 23, 2024
3 checks passed
@BenjaminLudwigSAP BenjaminLudwigSAP deleted the enable_session_mirroring_for_tcp branch July 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants