Parallelise the request to the vcenters #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code was generated on the fly, which couples the discovery tightly with the generation
It was never used
This moves all the template/yaml to the phelm module. Hopefully it is more encapsulated that way
This way, we manage a state per vcenter, and if a vcenter 'disappears', we do not modify the state, unless the vcenter becomes empty
There is no need for a queue of the state, and we can move the exception-handling in one place
Previously the poll loop contained more logic, by moving it to different functions it is easier to parallelise
With the increased number of vcenters, getting the data from them takes a increasingly longer time. By parallelising this part, we can at least reduce the waiting time for I/O
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation is to hide the latency when testing locally over VPN, but might also slightly improve the scalability in production.