Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing testing #271

Merged
merged 3 commits into from
Feb 26, 2024
Merged

fixing testing #271

merged 3 commits into from
Feb 26, 2024

Conversation

viennaa
Copy link
Collaborator

@viennaa viennaa commented Feb 22, 2024

not yet everything, but in general working way better than before

In TestCollectors this is still failing but I haven't found the culprit yet, to overwrite the necessary call.

Problem connecting to vrops-vcenter-test.company.com - Error: HTTPSConnectionPool(host='vrops-vcenter-test.company.com', port=443): Max retries exceeded with url: /suite-api/api/deployment/node/services/info (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x40063f5f10>: Failed to resolve 'vrops-vcenter-test.company.com' ([Errno -2] Name does not resolve)"))

@viennaa
partially fixing testing
14f2d46 
not yet everything, but in general working way better than before
@viennaa
fixing connection error
1948bfc
@viennaa
fixing test signal handling
1fc2086 
signal handling has changed and there is a ValueError if a subthread is trying to do signal handling. This signal mocking is addressing this issue
@viennaa viennaa changed the title partially fixing testing fixing testing Feb 26, 2024
@viennaa
Copy link
Collaborator Author

viennaa commented Feb 26, 2024

All testing fixed

richardtief
richardtief approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for fixing

@viennaa viennaa merged commit a841ebe into master Feb 26, 2024
1 check passed
@viennaa viennaa deleted the vrops_tests branch February 26, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtief richardtief richardtief approved these changes

@himanip94 himanip94 Awaiting requested review from himanip94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viennaa @richardtief