Code improvements

sarvekshayr · Jan 31, 2025 · 27ed6e0 · 27ed6e0
1 parent 143e923
commit 27ed6e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...ne/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java b/...ne/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java
@@ -58,7 +58,6 @@ public class TestOzoneRepairShell {
   private static MiniOzoneCluster cluster = null;
   private static OzoneConfiguration conf = null;
   private static String om;
-  private static TransactionInfoRepair transactionInfoRepair;
   private static final String TRANSACTION_INFO_TABLE_TERM_INDEX_PATTERN = "([0-9]+#[0-9]+)";
 
   @BeforeAll
@@ -67,7 +66,6 @@ public static void init() throws Exception {
     cluster = MiniOzoneCluster.newBuilder(conf).build();
     cluster.waitForClusterToBeReady();
     om = conf.get(OZONE_OM_ADDRESS_KEY);
-    transactionInfoRepair = new TransactionInfoRepair();
   }
 
   @BeforeEach
@@ -92,7 +90,7 @@ static void cleanup() {
   public void testUpdateTransactionInfoTable(Component component) throws Exception {
     CommandLine cmd = new OzoneRepair().getCmd();
     String dbPath = getDbPath(component);
-    String componentLowerCase = component.toString().toLowerCase();
+    String componentLowerCase = component.name().toLowerCase();
 
     cluster.getOzoneManager().stop();
     cluster.getStorageContainerManager().stop();
@@ -143,7 +141,7 @@ private String getDbPath(Component component) {
   private String scanTransactionInfoTable(String dbPath, Component component) {
     CommandLine debugCmd = new OzoneDebug().getCmd();
     debugCmd.execute("ldb", "--db", dbPath, "scan", "--column_family",
-        transactionInfoRepair.getColumnFamily(component).getName());
+        TransactionInfoRepair.getColumnFamily(component).getName());
     return out.get();
   }
 

diff --git a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/TransactionInfoRepair.java b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/TransactionInfoRepair.java
@@ -122,7 +122,7 @@ protected Component serviceToBeOffline() {
     }
   }
 
-  public DBColumnFamilyDefinition<String, TransactionInfo> getColumnFamily(Component component) {
+  public static DBColumnFamilyDefinition<String, TransactionInfo> getColumnFamily(Component component) {
     switch (component) {
     case OM:
       return OMDBDefinition.TRANSACTION_INFO_TABLE;