[FEATURE] Add rule to check if service is private #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabbelasichon
force-pushed
the
task/add-container-private-rule
branch
3 times, most recently
from
a4df992 to
7d5199e
Compare
sabbelasichon
force-pushed
the
task/add-container-private-rule
branch
from
7d5199e to
1753adb
Compare
sabbelasichon
changed the title
sabbelasichon
changed the title
sascha-egerer
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have something similar to https://github.com/phpstan/phpstan-symfony/blob/1.4.x/src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php in the repository
So if you have calls inside your code to get private services from the container (Service Locator Pattern) you will get a phpstan error.