-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 2 new request attribute mappings for TYPO3 v13 #165
Conversation
* Added `frontend.page.information` - see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendPageInformation.html#frontend-page-information * Added `frontend.cache.instruction` - see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendCacheInstruction.html#frontend-cache-instruction
We still need a way to make this TYPO3 version dependent as these types are now also valid in older TYPO3 versions with the current implementation. |
Can you elaborate what this means for this PR? Should we have different versions of the package for different TYPO3 versions or make But I'm also fine to just add the mapping to my custom |
I'm not yet sure how to solve the issue with supporting multiple TYPO3 versions. We do also have issues with the stubs where we already have a way to load them based on the TYPO3 version. But we really have to clean this up. I'll try to have a look at it soon. |
@derhansen I've merged #176 and did not notice that this is also part of your PR. So i wanted to rebase your's now and merge it but i'm not able to push into your PR. Could you please rebase remove the duplicate |
Done |
Added
frontend.page.information
- see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendPageInformation.html#frontend-page-informationAdded
frontend.cache.instruction
- see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendCacheInstruction.html#frontend-cache-instruction