[TASK] Port some type annotation improvements from the Core

[oliverklee]

The Core recently has received some improvements on the type annotations/declerations. Port those over to our stubs.

Also rearrage some union type to have null always last.

[oliverklee]

I don't quite understand why PHPStan cannot resolve the type for Repository::setDefaultOrderings(), and I would welcome any help.

[oliverklee]

Okay, I've simplified the type a bit for the time being to get this to green.

[sascha-egerer]

@oliverklee I‘m on vacation but I’ll have a look end of next week

[sascha-egerer]

Looks like the previous issue was due to a bug in PHPStan that is not reproducible in the PHPStan playground. Once phpstan has created it's result caches the error is gone. If i remove the result cache i get the error again. Executing phpstan once again is successful. So it is somehow a bug that does only occur if result caches are not active. I'll further investigate and create a phpstan issue once i have a minimal reproducable setup. Maybe it is also somehow related to other parts of this package - I'll investigate and come back soon.

[sascha-egerer]

Ok, reason is phpstan/phpstan#10967 and the text in the orange box: https://phpstan.org/user-guide/stub-files

Why is PHPStan complaining about “Class not found” in a stub file?

Stub files are analysed independently from the rest of your codebase. This means that any type they’re referencing must also be present as a stub, even if you don’t want to override any of its PHPDocs.

This is a way of tackling the problem of optional dependencies. We want to report any undefined names used in the stubs to prevent typos, but at the same time we also need to support optional dependencies in PHPStan extensions. That’s why all the symbols must be defined again in the stubs, even as empty shells.

[sascha-egerer]

@oliverklee Looks like i'm not allowed to push my changes to your fork so i just made code suggestions.

[sascha-egerer]

@oliverklee Ok i was able to commit them via the GitHub interface. weird... But it should work now as expected.

[oliverklee]

@sascha-egerer Looks good, thanks! 🙏