Address review

sass · Dec 4, 2023 · b3f5414 · b3f5414
1 parent 5a5cfd2
commit b3f5414
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/src/importer-registry.ts b/lib/src/importer-registry.ts
@@ -54,18 +54,19 @@ export class ImporterRegistry<sync extends 'sync' | 'async'> {
   /** Converts an importer to a proto without adding it to `this.importers`. */
   register(
     importer: Importer<sync> | FileImporter<sync> | NodePackageImporter,
-    _entryPointURL?: string | URL
+    providedEntryPointURL?: string | URL
   ): proto.InboundMessage_CompileRequest_Importer {
     const message = new proto.InboundMessage_CompileRequest_Importer();
     if (typeof importer === 'symbol') {
       if (importer !== nodePackageImporter) {
-        throw 'Incorrect Node Package Importer used';
+        throw 'Unknown importer ${importer}';
       }
       const importerMessage = new proto.NodePackageImporter();
-      let entryPointURL = _entryPointURL ?? require.main?.filename;
+      let entryPointURL = providedEntryPointURL ?? require.main?.filename;
       entryPointURL = entryPointURL?.toString();
-      if (entryPointURL === legacyImporterProtocol)
+      if (entryPointURL === legacyImporterProtocol){
         entryPointURL = require.main?.filename;
+      }
 
       if (!entryPointURL) {
         throw new Error(

diff --git a/lib/src/legacy/index.ts b/lib/src/legacy/index.ts
@@ -175,7 +175,7 @@ function convertOptions<sync extends 'sync' | 'async'>(
   };
 
   // Use separate return statements, as applying logic directly to the inclusion
-  // of `nodePackageImporter` causes the symbol to use its unique flag.
+  // of `nodePackageImporter` causes the symbol to lose its unique flag.
   // See https://github.com/microsoft/TypeScript/issues/55901
   if (options.pkgImporter === 'node') {
     importers = importers || [];