Use process.argv[1] as a fallback for new NodePackageImporter()
#275
Conversation
lib/src/importer-registry.ts
Outdated
| @@ -21,6 +22,10 @@ export class NodePackageImporter { | |||
| ? p.resolve(entryPointDirectory) | |||
| : require.main?.filename | |||
| ? p.dirname(require.main.filename) | |||
| // TODO: Find a way to use `import.meta.main` once | |||
| // https://github.com/nodejs/node/issues/49440 is done. | |||
| : process.argv[1] | |||
There was a problem hiding this comment.
A small risk here is that process.argv is mutable and can be mutated before this is executed. Otherwise this would be a pretty good workaround for ESM.
There was a problem hiding this comment.
I don't think we can avoid that issue here. At least if users run into it, they always have the option of passing something in explicitly to work around it.
There was a problem hiding this comment.
If I understand the concern correctly, this also applies to require.main.filename. We take advantage of that for testing different scenarios for CommonJS.
There was a problem hiding this comment.
Yes, but the chance of argv getting modified would be higher as it’s pretty common to do something like arg = argv.shift() when parsing arguments.
Closes #274