-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ssl problem in bioc_install command #9349
Fix ssl problem in bioc_install command #9349
Conversation
Deal with ssl problem in bioc_install command
… is supplied correctly
It turns out that the variable |
Thanks for this. Because of the Appveyor error, this PR is the first to pass CI checks in more than a year. I hope the maintainers will merge this or pursue something like #7751. |
@roi-meir I can't tell you how much I appreciate the effort you put into getting these checks back up and running 🙏 As @rharao pointed out, we are planning to move away from AppVeyor in favor of GitHub actions and #9538 drops the corresponding config files accordingly. On second thought, there's probably utility in having both sets of checks running concurrently for a little while to make sure nothing is sneaking through the new set that shouldn't be (in general the new checks should be stricter than the old but still). Unless you've got any objections, I'll revert d669d9d and then squash-merge |
Sound good for me. |
Closing in favor of: |
Problem
Currently, the tests fail at the first
bioc_install
command because of SSL errorFor example:
Fix
Set R_LIBCURL_SSL_REVOKE_BEST_EFFORT to TRUE (see https://stat.ethz.ch/R-manual/R-devel/library/utils/html/download.file.html for details)