Remove outdated .Build.cs template #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs already reference the Alpakit template in the master branch of the SML repo, so there's no need to maintain a copy of the template that is bound to become outdated over time. Also, update the name to replace to `PLUGIN_NAME` as used in the Alpakit template.
budak7273
requested changes
Oct 24, 2024
Comment on lines
74
to
81
|
|
||
| Within this new file you will need to add the following configuration text. | ||
|
|
||
| Make sure to replace all instances of `YourModReference` with your actual mod reference. | ||
| Make sure to replace all instances of `PLUGIN_NAME` with your actual mod reference. | ||
|
|
||
| The latest version of this template can be found in the | ||
| https://github.com/satisfactorymodding/SatisfactoryModLoader/blob/master/Mods/Alpakit/Templates/CPPAndBlueprintBlank/Source/PLUGIN_NAME/PLUGIN_NAME.Build.cs[Starter Project Repository as an Alpakit template]. | ||
|
|
There was a problem hiding this comment.
Could you reorder+rephrase this so it's saying to visit the template file, then telling you how to edit it? Right now it's in reverse. I'm on mobile so cant use the Suggest feature easily
There was a problem hiding this comment.
I swapped the paragraphs' order, I think it's reasonable enough but I'd like to know what your thoughts are.
Hopefully, this is what Robb meant.
budak7273
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs already reference the Alpakit template in the master branch of the SML repo, so there's no need to maintain a copy of the template that is bound to become outdated over time. Also, update the name to replace to
PLUGIN_NAMEas used in the Alpakit template.