This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
feat: add ability to type tab names with SceneRendererProps #1247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to add more strength to my typings while using the lib. I don't want to make mistakes while using tab names.
Test plan
This is a non breaking change. I can't think of any risk with this.
Here's when I add a type parameter (new behaviour):
Here's when I don't (same as previous behaviour):
Thank you!