Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

feat: add ability to type tab names with SceneRendererProps #1247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierpo
Copy link

@pierpo pierpo commented Aug 19, 2021

Motivation

I'd like to add more strength to my typings while using the lib. I don't want to make mistakes while using tab names.

Test plan

This is a non breaking change. I can't think of any risk with this.

Here's when I add a type parameter (new behaviour):

image

Here's when I don't (same as previous behaviour):

image

Thank you!

@github-actions
Copy link

Hey pierpo! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant