-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Contributors Page in the website. #184
Added the Contributors Page in the website. #184
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for scrollme-ecommerce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@tarunkumar2005 where I access this page can you give the title of this page to access this |
@thakuratul2 /contributors |
@tarunkumar2005 mentioned in the website too then we can access by click on the header |
@thakuratul2 In the navbar or footer ?? |
@tarunkumar2005 in the footer |
@tarunkumar2005 mentioned the mentor and project admin which are and mentioned contributor title in the new user |
@thakuratul2 Okay in api it is showing all of them same user only i will explecityly mention them as admins and mentors can you tell me who all are admins and mentors. |
@tarunkumar2005 only mention mentor as me and admin as @saurabhbakolia |
…ributors page link in the footer.
@thakuratul2 Now check it is updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarunkumar2005 can you provide the video
Recording.2024-10-12.125939.mp4 |
@saurabhbakolia please merge it |
@thakuratul2 and @saurabhbakolia Pending PR (reminder) |
Hey @tarunkumar2005, Thanks for your efforts! |
@saurabhbakolia Will do that and update the PR but don't take too much time to respond i know you might not be free and busy but like take some time like a hour or so to just go through the PRs and get them reviewed that is a request it's been open from last week. also check this one #178 |
@saurabhbakolia Please check now i have updated the ui according to the theme. i hope you will give updates on it soon either you have any issue or merge it. |
@saurabhbakolia @thakuratul2 Bro it is took me so much time and contntinous updates with matching theme, responsive design and perfect page, you can at least put it level 3, i talked to sajay sir and he said for this much good design and perfection you need to give atleast level 3. |
who is this guy (Sanjay). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarunkumar2005 done
when did i say that? @tarunkumar2005 dont pull my name on unnecessary PR. if there any issue with the labels project admin assign you. as a program manager i can help and fix any issue. |
@sanjay-kv you can check yourself how much efforts it takes to design the ui like this with proper functionality and I don't want to put the issue in the discussion every time so I directly said it soo I had raised a issue is discussion you can check that same thing was there. |
okay got it.. @tarunkumar2005 |
Pull Request Template
Added the Contributors Page in the website.
Description
Added the Contributors Page in the website.
Related Issue
Fixes #182
Checklist
Screenshots (if applicable)
@thakuratul2 @saurabhbakolia Please review this PR and merge it and before this merge #178 PR and assign this to me and put relevant labels like gssoc 2024 ext, hacktoberfest and level.