Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Contributors Page in the website. #184

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

tarunkumar2005
Copy link
Contributor

Pull Request Template

Added the Contributors Page in the website.

Description

Added the Contributors Page in the website.

Related Issue

Fixes #182

Checklist

  • I have tested my code and it works as expected.
  • I have added/updated documentation where necessary.
  • I have included tests for new features.
  • I have followed the project's coding standards.

Screenshots (if applicable)

image

image

@thakuratul2 @saurabhbakolia Please review this PR and merge it and before this merge #178 PR and assign this to me and put relevant labels like gssoc 2024 ext, hacktoberfest and level.

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scrollme-ecommerce-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 11:27am

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for scrollme-ecommerce ready!

Name Link
🔨 Latest commit 8e2abe0
🔍 Latest deploy log https://app.netlify.com/sites/scrollme-ecommerce/deploys/6710f43fb1df670008b64d9e
😎 Deploy Preview https://deploy-preview-184--scrollme-ecommerce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thakuratul2
Copy link
Collaborator

@tarunkumar2005 where I access this page can you give the title of this page to access this

@tarunkumar2005
Copy link
Contributor Author

@thakuratul2 /contributors

@thakuratul2
Copy link
Collaborator

@tarunkumar2005 mentioned in the website too then we can access by click on the header

@tarunkumar2005
Copy link
Contributor Author

@thakuratul2 In the navbar or footer ??

@thakuratul2
Copy link
Collaborator

@tarunkumar2005 in the footer

@thakuratul2
Copy link
Collaborator

@tarunkumar2005 mentioned the mentor and project admin which are and mentioned contributor title in the new user

@tarunkumar2005
Copy link
Contributor Author

@thakuratul2 Okay in api it is showing all of them same user only i will explecityly mention them as admins and mentors can you tell me who all are admins and mentors.

@thakuratul2
Copy link
Collaborator

@tarunkumar2005 only mention mentor as me and admin as @saurabhbakolia

@tarunkumar2005
Copy link
Contributor Author

@thakuratul2 Now check it is updated

Copy link
Collaborator

@thakuratul2 thakuratul2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunkumar2005 can you provide the video

@tarunkumar2005
Copy link
Contributor Author

Recording.2024-10-12.125939.mp4

@thakuratul2
Copy link
Collaborator

@saurabhbakolia please merge it

@tarunkumar2005
Copy link
Contributor Author

@thakuratul2 and @saurabhbakolia Pending PR (reminder)

@thakuratul2 thakuratul2 self-requested a review October 16, 2024 16:06
@saurabhbakolia
Copy link
Owner

Hey @tarunkumar2005,
I’m really impressed by the work you’ve done on the contribution page! However, could you please adjust the colors to align with the existing theme?

Thanks for your efforts!

@tarunkumar2005
Copy link
Contributor Author

@saurabhbakolia Will do that and update the PR but don't take too much time to respond i know you might not be free and busy but like take some time like a hour or so to just go through the PRs and get them reviewed that is a request it's been open from last week. also check this one #178

@tarunkumar2005
Copy link
Contributor Author

@saurabhbakolia Please check now i have updated the ui according to the theme. i hope you will give updates on it soon either you have any issue or merge it.

@saurabhbakolia saurabhbakolia added the gssoc-ext GSSOC Extd 2024 label Oct 18, 2024
@tarunkumar2005
Copy link
Contributor Author

@saurabhbakolia @thakuratul2 Bro it is took me so much time and contntinous updates with matching theme, responsive design and perfect page, you can at least put it level 3, i talked to sajay sir and he said for this much good design and perfection you need to give atleast level 3.

@saurabhbakolia saurabhbakolia added level3 Level 3 and removed level2 Level 2 labels Oct 18, 2024
@saurabhbakolia
Copy link
Owner

@saurabhbakolia @thakuratul2 Bro it is took me so much time and contntinous updates with matching theme, responsive design and perfect page, you can at least put it level 3, i talked to sajay sir and he said for this much good design and perfection you need to give at least level 3.

who is this guy (Sanjay).

@tarunkumar2005
Copy link
Contributor Author

@sanjay-kv

Copy link
Collaborator

@thakuratul2 thakuratul2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhbakolia saurabhbakolia merged commit 8486189 into saurabhbakolia:develop Oct 18, 2024
7 checks passed
@sanjay-kv
Copy link
Collaborator

sanjay-kv commented Oct 21, 2024

saurabhbakolia

when did i say that? @tarunkumar2005

dont pull my name on unnecessary PR. if there any issue with the labels project admin assign you.

as a program manager i can help and fix any issue.

@tarunkumar2005
Copy link
Contributor Author

@sanjay-kv you can check yourself how much efforts it takes to design the ui like this with proper functionality and I don't want to put the issue in the discussion every time so I directly said it soo I had raised a issue is discussion you can check that same thing was there.

@sanjay-kv
Copy link
Collaborator

okay got it.. @tarunkumar2005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants