Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zoom-In Feature for Product Images #208

Closed
wants to merge 5 commits into from
Closed

Add Zoom-In Feature for Product Images #208

wants to merge 5 commits into from

Conversation

Paniv45
Copy link

@Paniv45 Paniv45 commented Oct 16, 2024

This pull request introduces a zoom-in feature for product images in the ScrollMe e-commerce website. The changes enhance the user experience by allowing customers to view product details more closely, helping them make informed purchase decisions.

Changes Made:
Modified the src/pages/Product.jsx file to implement the zoom-in functionality on product images.
Ensured that the zoom feature is user-friendly and does not disrupt the overall layout of the product page.
Related Issues:
None at the moment, but this feature aims to improve usability and visual appeal.
Please review the changes and let me know if any modifications are needed or if you have any questions!
Screenshot 2024-10-16 171600

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scrollme-ecommerce-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 5:43am

@Paniv45
Copy link
Author

Paniv45 commented Oct 16, 2024

Kindly accept my 2nd commit "zoom-in feature for product images" to enable the feature for the site.

@Paniv45
Copy link
Author

Paniv45 commented Oct 17, 2024

Kindly Approve it

@saurabhbakolia
Copy link
Owner

Hey @Paniv45,

It is not looking good.
can you come up with something creative?

@Paniv45
Copy link
Author

Paniv45 commented Oct 19, 2024

What else do you want? Any suggestions? What if when the user goes to a particular product page the and clicks on the product image it gets enlarged as shown above and than we can add a feature that user can rotate the product image 360 degree to view the product from different angle. I am sure that it will provide user a clear picture of how the product exactly looks and help the user to deicide accordingly. Or we can add a rotation bar which sets the angle at which user wants to view the product image

@Paniv45
Copy link
Author

Paniv45 commented Oct 19, 2024

Kindly give suggestions if you have any.

@Paniv45
Copy link
Author

Paniv45 commented Oct 19, 2024

I had updated 360 degree rotation view for the product image kindly review it and if you have any suggestion kindly tell me.

@saurabhbakolia
Copy link
Owner

I had updated 360 degree rotation view for the product image kindly review it and if you have any suggestion kindly tell me.

Hey @Paniv45,
Kindly share the video if you have made new changes.
and regarding the suggestion, you can check amazon or myntra website. We can add something like that.

@Paniv45
Copy link
Author

Paniv45 commented Oct 19, 2024 via email

@saurabhbakolia
Copy link
Owner

saurabhbakolia commented Oct 19, 2024

Hey @Paniv45 ,
I think the previous one was way better than this rotation one.

Also, can you make it like this?
image
image

@Paniv45
Copy link
Author

Paniv45 commented Oct 20, 2024

Done with the suitable changes and made a pull request from the name "Finalization of zoom in feature" .

@saurabhbakolia
Copy link
Owner

Hey @Paniv45,
You again made the same mistake. Create a pr to develop branch.

@Paniv45 Paniv45 closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants