Fix getopt parameters #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long-format options that need values weren't defined correctly causing failure to parse the corresponding values from the command line. This fixes it (single : for required, double for optional, none for none).
|
Thank you! I didn't have much experience with bash script previously. |
|
Released as update v0.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters passed to
getopthave a few discrepancies which can cause unexpected behaviour depending on which args are passed.--interval,--cyclesand--packages-limit:Missing the
:meant only the short options would receive the value-dand long-format--develargs:Redundant
::for a flag that takes no value (mostly harmless)The
-n/--notifyflag was also missing, which combined withshift 2meant a command likewaybar-updates -n -dwould eat the-d.