Skip to content

Commit

Permalink
Merge pull request #693 from zcross/zcross/secure-random-over-uuid
Browse files Browse the repository at this point in the history
Replace UUID with SecureRandom.uuid
  • Loading branch information
tjarratt committed Jun 5, 2015
2 parents 2f82b7d + 172036f commit 8da1f3c
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 2.11.1 (2015-05-27)

* Replace dependency on [uuid](https://rubygems.org/gems/uuid), using SecureRandom.uuid instead.

# 2.11.0 (2015-03-31)

* Formally drop support for 1.8.7.
Expand Down
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ gem "httpclient", "~> 2.3.4"

gem "simplecov", :require => false
gem "coveralls", :require => false
gem "uuid"

platform :rbx do
gem 'json'
Expand Down
4 changes: 2 additions & 2 deletions lib/savon/header.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "akami"
require "gyoku"
require "uuid"
require "securerandom"

module Savon
class Header
Expand Down Expand Up @@ -61,7 +61,7 @@ def build_wsa_header
convert_to_xml({
'wsa:Action' => @locals[:soap_action],
'wsa:To' => @globals[:endpoint],
'wsa:MessageID' => "urn:uuid:#{UUID.new.generate}",
'wsa:MessageID' => "urn:uuid:#{SecureRandom.uuid}",
attributes!: {
'wsa:MessageID' => {
"xmlns:wsa" => "http://schemas.xmlsoap.org/ws/2004/08/addressing"
Expand Down
2 changes: 1 addition & 1 deletion lib/savon/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Savon
VERSION = '2.11.0'
VERSION = '2.11.1'
end
1 change: 0 additions & 1 deletion savon.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ Gem::Specification.new do |s|
s.add_dependency "wasabi", "~> 3.4"
s.add_dependency "akami", "~> 1.2"
s.add_dependency "gyoku", "~> 1.2"
s.add_dependency "uuid", "~> 2.3.7"
s.add_dependency "builder", ">= 2.1.2"
s.add_dependency "nokogiri", ">= 1.4.0"

Expand Down

0 comments on commit 8da1f3c

Please sign in to comment.