Tidy up of Paths related to Battery and Alternator #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path ending in .mode reflected the /State dbus value and no /State was available in the paths.
With the addition of WS500 Alternator monitoring in Venus 2.90 the dbus paths have been locked and a few names changed.
|
Please split the wind/temp stuff to a separate PR |
|
@sbender9 Done. |
|
I worry a little about changing mode to state. This could break peoples setup if they're already using it, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths for the Lynx Smart BMS did not map widely /Mode and /State mixed up. The release of Venus 2.90 includes formal support for WS500 alternator monitoring so tidy up of the /State and /Link/NetworkStatus.