Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config File and Event Criterias #35

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dominik-strutz
Copy link

This Request contains all the changes necessary to use a Configuration File to set up all settings. It is still possible to use the command line to change the settings. The Request contains changes in the way events are handled as well. It is now possible to give more than one Criteria for Events. A minimum and a maximum Magnitude for a minimum and maximum distance. And the event times are now corrected for the propagation time. The time you see in the plot is the first arrival at your station.

… commit contains all the changes necessary to use a Configuration File to set up all settings. It is still possible to use the command line to change the settings. The commit contains changes in the way events are handled as well. It is now possible to give more than one Criteria for Events. A minimum and a maximum Magnitude for a minimum and maximum distance. And the event times are now corrected for the runtime. So the time you see is the first arrival at your station.
@megies
Copy link
Collaborator

megies commented Feb 20, 2019

Regarding the config files, can you please use # consistently for comments and avoid the --------------------------- separator lines maybe?

@megies
Copy link
Collaborator

megies commented Feb 20, 2019

I think I'd prefer *.cfg as filenames for these three config files

This was referenced Feb 20, 2019
@megies
Copy link
Collaborator

megies commented Feb 20, 2019

Please add configargparse as an install dependency in setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants