Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty name on dashboard #1010 #1011

Merged
merged 2 commits into from
Nov 16, 2024
Merged

fix: Empty name on dashboard #1010 #1011

merged 2 commits into from
Nov 16, 2024

Conversation

Rushaway
Copy link
Contributor

@Rushaway Rushaway commented Nov 14, 2024

Description

Add a missing empty player string check

Motivation and Context

#1010

How Has This Been Tested?

Inserted an empty name into db and then apply the fix

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Hackmastr Hackmastr merged commit 9ed8db1 into sbpp:php81 Nov 16, 2024
3 checks passed
@Rushaway Rushaway deleted the 1010 branch November 16, 2024 15:05
DNA-styx added a commit to DNA-styx/SBPP-Windmill-Dashboard that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants