Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backmerge 10-26-24 #146

Merged
merged 10 commits into from
Oct 27, 2024
Merged

backmerge 10-26-24 #146

merged 10 commits into from
Oct 27, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Oct 26, 2024

NOTE: We shouldn't squash and merge, instead we should do a normal merge commit

@rin-st
Copy link
Member

rin-st commented Oct 26, 2024

Fixed zustand import since default export is dropped . Not sure why it was default here but not default on se-2 though

@technophile-04
Copy link
Collaborator Author

Fixed zustand import since default export is dropped . Not sure why it was default here but not default on se-2 though

Ohh thanks Rinat! Yeah its strange that it didn't picked it up

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Just letting you know, I updated onchainkit extension so it wont break after this merge scaffold-eth/create-eth-extensions@52399f7

@technophile-04 technophile-04 merged commit 0f87af8 into main Oct 27, 2024
1 check passed
@technophile-04 technophile-04 deleted the backmerge-10-26-24 branch October 27, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants