Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure lint gh-action #40

Merged
merged 3 commits into from
May 29, 2024
Merged

configure lint gh-action #40

merged 3 commits into from
May 29, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented May 28, 2024

Description

Created a lint workflow similar to SE-2 repo which runs wherever a PR is created against main and after merging / pushing things to main.

Here is failed example, where I commited with --no-verify flag an un formatted code https://github.com/scaffold-eth/create-eth/actions/runs/9272915257/job/25511808068

Fixes #22

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Collaborator

@damianmarti damianmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Thanks!!

@carletex carletex merged commit 764d5c2 into main May 29, 2024
1 check passed
@carletex carletex deleted the gh-actions branch May 29, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup github action for CLI (basic version)
4 participants