templatised foundry deploy script

[technophile-04]

Description :

This will allow people to create extension's which adds new contract and also deployments for them.

To test :

Switch to this branch then:

1. Start cli :

yarn dev

2. Scaffold new app, with eip-5792 extension:

yarn cli -e technophile-04/eip-5792:foundry

3. Choose foundry as extension too

Here is extension repo

---

Adding contracts and deployments in hardhat does not require any templatisation since we can create separate 01_deploy_.. file and main deploy script 99_deploy... will consider all the deployments.

But in foundry this is not the case checkout this for more details

[rin-st]

Thanks Shiv, good job!

Trying to run

yarn cli -e technophile-04/eip-5792:foundry

and getting this error when deploying contracts (sorry for screenshots, adding as images because of colors)

if I move vm.stopBroadcast() upper in Deploy.s.sol

    vm.startBroadcast(deployerPrivateKey);

    YourContract yourContract = new YourContract(vm.addr(deployerPrivateKey));
    console.logString(string.concat("YourContract deployed at: ", vm.toString(address(yourContract))));

    vm.stopBroadcast();

    DeployExampleContract deployExampleContract = new DeployExampleContract();
    deployExampleContract.run();

I'm getting this error

Looks like DeployHelpers.s.sol should create folder/files if they don't exist.

Upd. Added empty deployments/31337.json and deployment worked 🎉 . But looks like it should be changed in another pr.

[technophile-04]

Upd. Added empty deployments/31337.json and deployment worked 🎉 . But looks like it should be changed in another pr.

Ohh yeah thanks !, actually this bug was introduced in #38 and currently present main.

In #38 we removed .gitignore from foundry/deployments and since .gitignore was only file present in deployments git removed the whole deployments dir and stopped tracking it.

Fixed this at 8e2f18d by adding deployments/31337.json this makes sure that deployments dir is present when we run yarn deploy. We can't have empty deployments in cli template since git is not able to track it. But I think its fine to have deployments/31337.json already present since 31337 is any which way git ignored in scaffolded app and also it just a small file which mentions name of the network so its always deterministic

[rin-st]

Lgtm! Thank you!

[technophile-04]

Merging this, thanks !! 🙌